use cmdtrl-enter to run a cell #5120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of ctrl-enter to run a cell, use cmdtrl-enter - this will provide better ux for mac users.
blink1073
approved these changes
May 21, 2020
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
|
Why would this be changed after several years of using notebook. I was used to control+enter. I've been using notebook for several years and didn't have issues using control+enter. I don't understand how you could say it for everyone? I would have recommended this as a command mode entry, but since edit mode shortcuts can't be changed, it's an arbitrary decision to change this. |
Member
|
I suspect this side-effect wasn't intended at the time this PR was merged. As others are also having some issues with this change, I suggest we move the discussion to #5794 for how this can be best addressed. Thanks. |
|
Thanks!! I hope it's addressed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ctrl-enter to run a cell, use cmdtrl-enter - this will provide better ux for mac users.